Subject: Re: 2.2.11 segfaults
From: Michal Jaegermann (michal@ellpspace.math.ualberta.ca)
Date: Thu Aug 12 1999 - 17:34:42 PDT
Nils Faerber wrote:
>
> Up to now 2.2.11 had no problems with my machein so far! (knocking on wood,
> crossing fingers, pressing thumbs and so on ;)
Well, this small change is likely good. The problem does not affect
everybody but when it hits you are dead with "Out of memory" in five
minutes.
Michal
p.s. it may be wise to modify this by hand (or 'patch -l'). Blanks
may be messed up.
From: "David S. Miller" <davem@redhat.com>
Date: Thu, 12 Aug 1999 08:33:43 -0700
Subject: Re: 2.2.11: Complicated memory leak...
Date: Thu, 12 Aug 1999 17:29:05 +0100 (BST)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
This isnt the bug however. I have reports from other network card
cases, and that backing rtl8139.c out doesnt change it. It seems to
have appeared about the time the 2nd set of TCP changes went in
Bingo, here is what I think the fix is. Everyone please test this...
Alan, once people have tested and verified this I will send you the
final version of the diff so that the CVS Id's are up to snuff too...
--- net/ipv4/tcp_ipv4.c.~1~ Mon Aug 9 12:05:14 1999
+++ net/ipv4/tcp_ipv4.c Thu Aug 12 08:30:34 1999
@@ -1778,13 +1778,12 @@
case TCP_TW_ACK:
tcp_v4_send_ack(skb, ((struct tcp_tw_bucket *)sk)->snd_nxt,
((struct tcp_tw_bucket *)sk)->rcv_nxt);
- break;
+ goto discard_it;
case TCP_TW_RST:
goto no_tcp_socket;
default:
goto discard_it;
}
- return 0;
}
static void __tcp_v4_rehash(struct sock *sk)
- --- net/ipv6/tcp_ipv6.c.~1~ Mon Aug 9 12:05:14 1999
+++ net/ipv6/tcp_ipv6.c Thu Aug 12 08:30:51 1999
@@ -1465,14 +1465,12 @@
case TCP_TW_ACK:
tcp_v6_send_ack(skb, ((struct tcp_tw_bucket *)sk)->snd_nxt,
((struct tcp_tw_bucket *)sk)->rcv_nxt);
- break;
+ goto discard_it;
case TCP_TW_RST:
goto no_tcp_socket;
default:
goto discard_it;
}
-
- return 0;
}
static int tcp_v6_rebuild_header(struct sock *sk)
-- To unsubscribe: send e-mail to axp-list-request@redhat.com with 'unsubscribe' as the subject. Do not send it to axp-list@redhat.com
This archive was generated by hypermail 2a22 : Tue Sep 07 1999 - 16:14:59 PDT