Re: timeout printing bug in ipfwadm

David Mosberger-Tang (davidm@AZStarNet.com)
Sun, 28 Jul 1996 16:41:58 -0700

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Bryan W. Headley: "Re: Questions"
Previous message: Jay Estabrook - Alpha Migration Tools - LINUX Project: "Re: UDB Network Card Errors"
Maybe in reply to: Richard Henderson: "timeout printing bug in ipfwadm"

Richard> Enclosed is a patch to ipfwadm.c to deal with system
Richard> clocks not running at 100Hz.

Richard> --- ipfwadm.c.orig Mon Jun 17 05:33:11 1996
Richard> +++ ipfwadm.c Thu Jul 25 18:35:24 1996
Richard> @@ -100,6 +100,10 @@
Richard> #include <linux/ip_fw.h>
Richard> #include <asm/param.h>
Richard>
Richard> +#ifndef HZ
Richard> +#define HZ __KERNEL_HZ
Richard> +#endif
Richard> +
Richard> #ifndef IP_FW_F_REDIR
Richard> #define IPFWADM_NO_REDIR
Richard> #define IP_FW_F_REDIR 0

Please do not refer to __KERNEL_* macros in any applications---ever.
The correct solution in this case is to include <sys/param.h> instead
of <asm/param.h>. As far as I know, this will work both for the "old"
libc and GNU libc.

I realize that ipfwadm.c is Linux specific (if there is such a thing),
but I'm worried about setting a bad example. The __KERNEL_* macros
are only for communicating system-specific information to libc.

--david

--
To unsubscribe: mail -s unsubscribe axp-list-request@redhat.com < /dev/null

Next message: Bryan W. Headley: "Re: Questions"
Previous message: Jay Estabrook - Alpha Migration Tools - LINUX Project: "Re: UDB Network Card Errors"
Maybe in reply to: Richard Henderson: "timeout printing bug in ipfwadm"